[nycphp-talk] Code Reviews

Justin Dearing zippy1981 at
Mon Jan 4 12:24:31 EST 2010

On Wed, Dec 30, 2009 at 11:18 AM, Tom Melendez <tom at> wrote:

> 2. You find something wrong, then what?  And what if it is not
> "really" wrong (Jones uses a selection sort but sould have used an
> insertion sort, and no one told him beforehand).  Do we hold up the
> project until the engs figure out what is best, even though the code
> "works"?  Good luck explaining that to mgmt.  And politically, it can
> make Jones look bad unnecessarily, yet, as the new guy on the team, he
> might not be familiar with the standards, practices, etc. of your
> group.
> Most of the time you probably shouldn't make the change. However, a little
//TODO (or @todo if you use a javadoc workalike)  means when that routine
needs to be optimized you will find it faster. Also, Jones now knows to use
an insertion sort next time. The code review can be an
educational opportunity for next time.

If the code review makes Jones look bad then you either need to remove
nontechnical management from the code review his peers need to have
reasonable expectations.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the talk mailing list